Skip to content

modify double np.hstack to single np.ravel #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

modify double np.hstack to single np.ravel #402

wants to merge 5 commits into from

Conversation

@February24-Lee
Copy link
Contributor 

# before
np.hstack(np.hstack(x))

# after
np.stack(x)

When I tested the time with 880,591 x 1 series data,
the running time improved from almost 2.5 seconds to within 1.0 second.

I thought the usage of double np.hstack was for StateType.sequence_numerical. In this case, np.stack will be fine. But if there is something I missed, please let me know.

@February24-Lee
Copy link
Contributor Author

oh, there were something I missed. I will check and re-try to PR

akihironitta
akihironitta reviewed Jan 5, 2025
View reviewed changes
Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improving performance in the codebase is always welcome! Let us know if you need any help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akihironitta akihironitta akihironitta left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@February24-Lee @akihironitta