Adding support for openml datasets #429
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiweny
reviewed
Aug 8, 2024
| self._task_type = ( | ||
| torch_frame.TaskType.MULTICLASS_CLASSIFICATION) | ||
| self._num_classes = int(self.dataset_info["NumberOfClasses"]) | ||
| col_to_stype[target_col] = torch_frame.categorical |
There was a problem hiding this comment.
Can you create a function to convert from openml TaskType to pytorch-frame TaskType and then call the function here?
There was a problem hiding this comment.
I don't think that's a good idea. Because the df here would be used in the constructor of the parent class. Also col_to_stype needs to get done before the constructor. If I am going to use a function to do this part, then df needs to be created as a new member variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a large number of datasets available in openml, and this PR adds support for the openml dataset, enabling the integration of openml and torch_frame. The dataset used can be specified using dataset_id.