Skip to content

Fix compatibility with rendercanvas 2.4.0 #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2025
Merged

Fix compatibility with rendercanvas 2.4.0 #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
acb43ba
Fix compatibility with rendercanvas 2.4.0
hmaarrfk Nov 10, 2025
7e17e5a
Merge branch 'main' into fix_rendercanvas_2.4.0
almarklein Nov 10, 2025
9891a57
use context where it makes sense
almarklein Nov 10, 2025
f286c6c
Merge branch 'main' into fix_rendercanvas_2.4.0
almarklein Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions examples/imgui_backend_sea.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,11 +341,8 @@ def gui(app_state):
# init imgui backend
imgui.create_context()
imgui_backend = ImguiWgpuBackend(device, render_texture_format)
imgui_backend.io.display_size = canvas.get_logical_size()
imgui_backend.io.display_framebuffer_scale = (
canvas.get_pixel_ratio(),
canvas.get_pixel_ratio(),
)
imgui_backend.io.display_size = present_context.logical_size
imgui_backend.io.display_framebuffer_scale = (present_context.pixel_ratio,) * 2


# register event handlers
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ tests = [
"imageio",
"anyio",
"trio",
"rendercanvas",
"rendercanvas>=2.4.0",
]
examples = ["pypng", "rendercanvas", "glfw"]
docs = ["sphinx>7.2", "sphinx_rtd_theme"]
Expand Down
8 changes: 4 additions & 4 deletions wgpu/utils/imgui/imgui_renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ def __init__(self, device, canvas, render_target_format=None):

self._backend = ImguiWgpuBackend(device, render_target_format)

self._backend.io.display_size = canvas.get_logical_size()
scale = canvas.get_pixel_ratio()
self._backend.io.display_size = self._canvas_context.logical_size
scale = self._canvas_context.pixel_ratio
self._backend.io.display_framebuffer_scale = (scale, scale)

canvas.add_event_handler(self._on_resize, "resize")
Expand Down Expand Up @@ -144,8 +144,8 @@ def render(self):

imgui.set_current_context(self.imgui_context)

pixel_ratio = self._canvas_context.canvas.get_pixel_ratio()
lsize = self._canvas_context.canvas.get_logical_size()
pixel_ratio = self._canvas_context.pixel_ratio
lsize = self._canvas_context.logical_size
self._backend.io.display_framebuffer_scale = (pixel_ratio, pixel_ratio)
self._backend.io.display_size = lsize

Expand Down
Loading