fixing multiple patch for a module on editable installs #1949
+313
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in the issue pypa#1871 if happen that a module is distributed across multiple location all location should be included in .pth file. In this commit is the fix for that. Current behavior for this scenario is to overwrite and keep only the last one. P.S: ruff to an auto-format over this file. Hope doesn't hurt or I simply revert ruff autoformatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue #1871:
if happen that a module is distributed across multiple location all location, on editable install this should be included in .pth file.
In this commit is the fix for that. Current behavior for this scenario is to overwrite and keep only the last one.
P.S: ruff to an auto-format over this file. Hope doesn't hurt or I simply revert ruff autoformatting.