Skip to content

Support a SOURCE_DATE_EPOCH prior to 1980 #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support a SOURCE_DATE_EPOCH prior to 1980 #1999

wants to merge 1 commit into from

Conversation

branchvincent
Copy link

Fixes #1605

A common value for SOURCE_DATE_EPOCH is 0, which unfortunately breaks hatchling:

$ uv init --build-backend=hatch
$ SOURCE_DATE_EPOCH=0 uv build
# ...
  File "/opt/homebrew/Cellar/python@3.13/3.13.4/Frameworks/Python.framework/Versions/3.13/lib/python3.13/zipfile/__init__.py", line 412, in __init__
    raise ValueError('ZIP does not support timestamps before 1980')
ValueError: ZIP does not support timestamps before 1980

This clamps to 1980 instead (same as setuptools and flit-core. poetry also support this but defaults to 2016)

@branchvincent branchvincent mentioned this pull request Jun 11, 2025
Merged
ofek
ofek requested changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

backend/src/hatchling/builders/wheel.py Outdated

d = datetime.fromtimestamp(get_reproducible_timestamp(), timezone.utc)
# `zipfile.ZipInfo` does not support timestamps before 1980
min_ts = datetime(1980, 1, 1, tzinfo=timezone.utc).timestamp()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check the value first to avoid doing unnecessary work here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid constructing a datetime right? I just hard-coded the timestamp since the logic is simpler to me but lmk what you think

@branchvincent branchvincent requested a review from ofek September 29, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ofek ofek Awaiting requested review from ofek

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

zipfile will fail if SOURCE_DATE_EPOCH is before 1980

2 participants

@branchvincent @ofek