Use compression.zstd/backports.zstd instead of zstandard #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular zstandard does not ships with all the wheels of backports.zstd, and remove one dependency on 3.14+. Drawback might be some platforms may not package backports.zstd yet Closes pypa#2077
Carreau
force-pushed
the
compression-zstd
branch
from
053f787 to
73e1018
Compare
|
See also #2034 which took the approach of using the |
|
AH thanks, I don't know how I missed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular zstandard does not ships with all
the wheels of backports.zstd, and remove one
dependency on 3.14+.
Drawback might be some platforms may not package backports.zstd yet
Closes #2077
I can also do the same but conditionally using zstandard instead of
backports.zstd.It's also unclear to me where this codepath is tested (if tested).