-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix fatal config set error #13535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sepehr-rs
wants to merge
8
commits into
pypa:main
Choose a base branch
from
sepehr-rs:fix-config-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17
−1
Open
Fix fatal config set error #13535
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b8d2cde
Fix user configuration error when trying to change global settings
sepehr-rs 46518e1
Add news entry file
sepehr-rs 7614729
Merge branch 'main' into fix-config-error
sepehr-rs 34adca7
Update 13279.bugfix.rst
sepehr-rs d024fc8
Update configuration.py to avoid pre-commit errors
sepehr-rs 2abf374
Merge branch 'main' into fix-config-error
sepehr-rs 5022272
Merge branch 'main' into fix-config-error
sepehr-rs ae1b2e3
Merge branch 'main' into fix-config-error
sepehr-rs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fixed fatal error when using `PIP_CONFIG_FILE` environment variable with `pip config set` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure I follow what this is trying to say, you can you give me a high level description of what you want to convey to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing this!
I wanted to let the user know that when the
PIP_CONFIG_FILEenvironment variable is set, pip uses that file instead of its normal configuration hierarchy. As a result, some commands may not reflect changes made to this file, since it lies outside pip’s typical config scopes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about the following:
Although I'm not 100% sure what commands would't respect the changes. Do you mean "other invocations of pip that don't set
PIP_CONFIG_FILE"? Because I feel like it's relatively obvious that changing where pip gets its config from won't affect invocations that don't change where pip gets its config from... So letting the user know thatPIP_CONFIG_FILEis set should be enough of a hint for them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. Maybe something like this would work better:
Does this sound better to you?