Skip to content

Conversation

@shenxianpeng
Copy link
Contributor

closes #323

@shenxianpeng
Copy link
Contributor Author

From my test on the main branch, the CI has failed already without this change.

@miketheman
Copy link
Member

From my test on the main branch, the CI has failed already without this change.

Yes, looks like a recent update to docutils or pygments may have changed the output - would you want to make a separate PR that only updates the test outputs based on current dependencies?

@shenxianpeng
Copy link
Contributor Author

shenxianpeng commented Jan 17, 2025

It was Pygments, when I pinned it to v2.18.0, tests passed. maybe we could pin it to 2.18.0 and create a ticket to track and fix it in a future pull request.

only updates the test outputs based on current dependencies?

sure, will do. but I am not sure what you want me how to do. could you explain a bit?

@shenxianpeng
Copy link
Contributor Author

I’ve opened a new PR (#325) to update the test outputs, and all tests are now passing.

@shenxianpeng
Copy link
Contributor Author

shenxianpeng commented Jan 22, 2025

The test failure has been fixed in 87cbbdd and is ready for review @miketheman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Footnotes are not supported in Markdown

2 participants