Skip to content

Add form field macro #6393 #18423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add form field macro #6393 #18423

wants to merge 1 commit into from

Conversation

TeeVee99
Copy link

PR to address the issue mentioned here : #6393

Following Macros were added:

  • input_field
  • input_field_errors
  • input_field_label

The html generated before and after these changes were captured and it matched except for some dynamically generated Ids.
Diff Htmls.zip

Addressed the following issues :

  1. Maintain a proper ordering of the fields while calling the macro.
  2. Ensure the key-value mapping is used during macro calls.
  3. Translations are to be generated.
  4. Dynamically pass and use parameters as required in the macro.

Thanks to @kx-chen & @Ashton for the initial PRs!

@TeeVee99 TeeVee99 requested a review from a team as a code owner July 26, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TeeVee99