Skip to content

Clarify pytest_collection_finish occurs after setting session.items #14088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicoddemus merged 3 commits into from
Jan 6, 2026
Merged

Clarify pytest_collection_finish occurs after setting session.items #14088

nicoddemus merged 3 commits into from
Jan 6, 2026
+5 −2

Conversation

@Liam-DeVoe
Copy link
Contributor

@Liam-DeVoe Liam-DeVoe commented Jan 4, 2026

I thought I wouldn't have access to session.items inside pytest_collection_finish, which is not the case.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jan 4, 2026
nicoddemus
nicoddemus approved these changes Jan 6, 2026
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicoddemus nicoddemus merged commit 0e9db5f into pytest-dev:main Jan 6, 2026
33 checks passed
@nicoddemus nicoddemus added the backport 9.0.x apply to PRs at any point; backports the changes to the 9.0.x branch label Jan 6, 2026
@patchback
Copy link

patchback bot commented Jan 6, 2026 •
edited
Loading

Backport to 9.0.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/9.0.x/0e9db5fa5a8de151ab43e5d71e0e8192e0456b9d/pr-14088

Backported as #14089

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 6, 2026
@Liam-DeVoe @patchback
Clarify pytest_collection_finish occurs after setting `session.item…
4a69cf2 
…s` (#14088)

(cherry picked from commit 0e9db5f)
@patchback patchback bot mentioned this pull request Jan 6, 2026
Merged
nicoddemus pushed a commit that referenced this pull request Jan 6, 2026
@patchback @Liam-DeVoe
Clarify pytest_collection_finish occurs after setting `session.item…
0d33475 
…s` (#14088) (#14089)

(cherry picked from commit 0e9db5f)

Co-authored-by: Liam DeVoe <orionldevoe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

backport 9.0.x apply to PRs at any point; backports the changes to the 9.0.x branch bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Liam-DeVoe @nicoddemus