-
-
Notifications
You must be signed in to change notification settings - Fork 731
Python 3.14 and dependency upgrades #3430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jb3
commented
Oct 30, 2025
- Updates to Python 3.14 in pyproject & Docker
- Upgrades uv to 0.9
- Upgrades all dependencies to latest available version
- Implements fixes for 3.13 -> 3.14 changes
- Implements linting fixes for newer versions of Ruff & Python
onerandomusername
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All imports from future involving annotations should be cut entirely.
These are no longer required. Possibly added to the banned imports for ruff flake8-banned-api configuration as well.
16124ee to
6d9dda7
Compare
3ca8a3a to
71de537
Compare
|
Would you please prepare a pull for the bot contributing guide in the website to bump the necessary version for bot? |
Given it's one file, one line and is solely a content change I'm going to just update main when this is merged. |
71de537 to
67b01a4
Compare
jchristgit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is way too large to review. Please split it up into multiple smaller PRs.
As you have done with python-discord PRs before I recommend you review this commit-by-commit. Large diffs are primarily related to lockfiles and linting changes, for which exclusion is trivial. |
Ahead of further dependency upgrades for dependencies that do build fine on newer Python versions.
python-markdownify 1.2.0 changed the _convert_hN method on MarkdownConverters public (and renamed to convert_hN). Functionality remains the same, just needs a rename of the method.
Co-authored-by: onerandomusername <me@arielle.codes>
Co-authored-by: onerandomusername <me@arielle.codes>
67b01a4 to
acad2ea
Compare
Co-authored-by: ChrisLovering <ChrisLovering@users.noreply.github.com>
|
Message from the Office of @ChrisLovering: |
|
I agree with jc, bumping ruff can happen separately. |
|
can we revert this Pr and separate into multiple PRs so i can properly review? |
Chris, PRs are welcome, thanks. |