Skip to content

Conversation

@jb3
Copy link
Member

@jb3 jb3 commented Oct 30, 2025

  • Updates to Python 3.14 in pyproject & Docker
  • Upgrades uv to 0.9
  • Upgrades all dependencies to latest available version
  • Implements fixes for 3.13 -> 3.14 changes
  • Implements linting fixes for newer versions of Ruff & Python

@python-discord-policy-bot python-discord-policy-bot bot requested a review from a team October 30, 2025 21:28
Copy link
Contributor

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All imports from future involving annotations should be cut entirely.

These are no longer required. Possibly added to the banned imports for ruff flake8-banned-api configuration as well.

@jb3 jb3 force-pushed the jb3/3.14-upgrade branch 2 times, most recently from 16124ee to 6d9dda7 Compare October 30, 2025 22:43
@jb3 jb3 force-pushed the jb3/3.14-upgrade branch 2 times, most recently from 3ca8a3a to 71de537 Compare November 5, 2025 02:27
@jb3 jb3 requested a review from onerandomusername November 5, 2025 16:35
@onerandomusername
Copy link
Contributor

Would you please prepare a pull for the bot contributing guide in the website to bump the necessary version for bot?

@jb3
Copy link
Member Author

jb3 commented Nov 10, 2025

Would you please prepare a pull for the bot contributing guide in the website to bump the necessary version for bot?

Given it's one file, one line and is solely a content change I'm going to just update main when this is merged.

@jb3 jb3 force-pushed the jb3/3.14-upgrade branch from 71de537 to 67b01a4 Compare November 10, 2025 15:20
Copy link
Member

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way too large to review. Please split it up into multiple smaller PRs.

@jb3
Copy link
Member Author

jb3 commented Nov 10, 2025

This is way too large to review. Please split it up into multiple smaller PRs.

As you have done with python-discord PRs before I recommend you review this commit-by-commit. Large diffs are primarily related to lockfiles and linting changes, for which exclusion is trivial.

@jchristgit jchristgit self-requested a review November 10, 2025 18:36
@jb3 jb3 force-pushed the jb3/3.14-upgrade branch from 67b01a4 to acad2ea Compare November 10, 2025 18:41
Co-authored-by: ChrisLovering <ChrisLovering@users.noreply.github.com>
@jb3
Copy link
Member Author

jb3 commented Nov 10, 2025

Message from the Office of @ChrisLovering:

Screenshot 2025-11-10 at 18 55 01

@jb3 jb3 merged commit c1a3673 into main Nov 10, 2025
4 of 5 checks passed
@jb3 jb3 deleted the jb3/3.14-upgrade branch November 10, 2025 18:55
@onerandomusername
Copy link
Contributor

I agree with jc, bumping ruff can happen separately.

@ChrisLovering
Copy link
Member

can we revert this Pr and separate into multiple PRs so i can properly review?

@jb3 jb3 deployed to production November 10, 2025 18:57 — with GitHub Actions Active
@jb3
Copy link
Member Author

jb3 commented Nov 10, 2025

can we revert this Pr and separate into multiple PRs so i can properly review?

Chris, PRs are welcome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants