Skip to content

Conversation

@Peter554
Copy link
Collaborator

@Peter554 Peter554 commented Jan 21, 2025

I think it's helpful to benchmark this case, as it might be possible to take a shortcut when the contract is kept (I want to do this in the rust implementation, should be much faster when the contract is kept). We want to optimise for this case, since in most cases most contracts will be kept (CI is green most of the time).

I think it's helpful to benchmark this separately,
as it might be possible to take a shortcut when the contract
is kept. We want to optimize for this case, since in most cases
most contracts will be kept (CI is green most of the time).
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2025

CodSpeed Performance Report

Merging #179 will not alter performance

Comparing Peter554:benchmark-layers-kept (572d605) with master (ac959a9)

Summary

✅ 10 untouched benchmarks
🆕 4 new benchmarks
⁉️ 2 (👁 2) dropped benchmarks

Benchmarks breakdown

Benchmark master Peter554:benchmark-layers-kept Change
🆕 test_deep_layers_large_graph_kept N/A 1.5 s N/A
🆕 test_deep_layers_large_graph_violated N/A 1.5 s N/A
🆕 test_top_level_large_graph_kept N/A 765.3 ms N/A
🆕 test_top_level_large_graph_violated N/A 788 ms N/A
👁 test_deep_layers_large_graph 1.5 s N/A N/A
👁 test_top_level_large_graph 787 ms N/A N/A

Copy link
Collaborator

@seddonym seddonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea.

@seddonym seddonym merged commit 0523253 into python-grimp:master Jan 21, 2025
17 checks passed
@Peter554 Peter554 deleted the benchmark-layers-kept branch February 7, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants