Skip to content

Conversation

@Peter554
Copy link
Collaborator

@Peter554 Peter554 commented Feb 6, 2025

In the rust backed implementation this is significantly slower (currently), so lets add a benchmark to track this.

Related: #175

In the rust backed implementation this is significantly slower
(currently), so lets add a benchmark to track this.
We do this currently in import-linter remove_ignored_imports.
@Peter554 Peter554 force-pushed the add-benchmark.module-in-graph-modules branch from 4198e4b to f99d32d Compare February 6, 2025 11:54
@seddonym seddonym self-requested a review February 6, 2025 12:02
Copy link
Collaborator

@seddonym seddonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for adding

@seddonym seddonym merged commit 06401f4 into python-grimp:master Feb 6, 2025
16 checks passed
@Peter554 Peter554 deleted the add-benchmark.module-in-graph-modules branch February 6, 2025 12:03
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #180 will not alter performance

Comparing Peter554:add-benchmark.module-in-graph-modules (f99d32d) with master (0523253)

Summary

✅ 14 untouched benchmarks
🆕 2 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_graph_contains_module N/A 198.6 µs N/A
🆕 test_iterate_over_modules_in_graph N/A 2.9 ms N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants