Skip to content

Conversation

@seddonym
Copy link
Collaborator

@seddonym seddonym commented Feb 7, 2025

A few more benchmarks.

In particular, this fixes an issue relating to caching graph.modules pointed out in this comment.

@seddonym seddonym force-pushed the more-benchmarks-feb2025 branch from 8344fa4 to 7e1c324 Compare February 7, 2025 15:02
@seddonym seddonym mentioned this pull request Feb 7, 2025
@seddonym seddonym merged commit 63da233 into master Feb 7, 2025
16 checks passed
@Peter554 Peter554 mentioned this pull request Feb 7, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 7, 2025

CodSpeed Performance Report

Merging #184 will not alter performance

Comparing more-benchmarks-feb2025 (7e1c324) with master (06401f4)

Summary

✅ 14 untouched benchmarks
🆕 3 new benchmarks
⁉️ 2 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_get_import_details N/A 242.5 µs N/A
⁉️ test_graph_contains_module 198.7 µs N/A N/A
⁉️ test_iterate_over_modules_in_graph 2.9 ms N/A N/A
🆕 test_modules_property_first_access N/A 44.9 µs N/A
🆕 test_modules_property_many_accesses N/A 1 ms N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants