Skip to content

Conversation

@seddonym
Copy link
Collaborator

It's never brought any value to have an abstraction for the ImportGraph. So this removes the abstract class and then moves the concretion to the application layer.

[ ] Add tests for the change. In general, aim for full test coverage at the Python level. Rust tests are optional.
[ ] Add any appropriate documentation.
[ ] Add a summary of changes to CHANGELOG.rst.
[ ] Add your name to AUTHORS.rst.
[ ] Run just full-check.

It's never brought any value to have an abstraction for the
ImportGraph. So this removes the abstract class and then moves the
concretion to the application layer.
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #254 will not alter performance

Comparing no-dip-graph (a279485) with main (8ddc6fb)

Summary

✅ 23 untouched
⏩ 21 skipped1

Footnotes

  1. 21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@seddonym seddonym marked this pull request as ready for review October 21, 2025 08:20
@seddonym seddonym merged commit f6d1c4b into main Oct 21, 2025
21 checks passed
@seddonym seddonym deleted the no-dip-graph branch October 21, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants