Namespace root packages #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
CodSpeed Performance ReportMerging #267 will improve performances by 10.25%Comparing Summary
Benchmarks breakdown
Footnotes
|
Prior to this, subsequent sibling packages in the contents string would be incorrectly nested under the directory the line above, due to an assumption that the contents string would be dedented. This takes account of that.
As it's more flexible.
This internal change will make it easier to walk the filesystem regardless of how deep the first line of contents is.
This improves the debugging experience in IDEs.
seddonym
force-pushed
the
namespace-root-packages
branch
from
06c26e6 to
3e5bb04
Compare
This doesn't change the implementation yet, but it prepares us for supporting namespace packages passed in.
This pushes the NamespacePackageEncountered error up the call stack into the use case.
This gets us most of the way, but we still want to include the namespace packages in the graph too (depending on what's passed in).
This stops us from discovering Python modules that aren't importable.
Prior to this, an import of a namespace package would be included if include_external_packages=True but not if it was False. Although in practice it's unlikely that a module would import a namespace package, this makes the behaviour consistent.
seddonym
force-pushed
the
namespace-root-packages
branch
from
6688240 to
c76a1d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for passing in native namespace packages as
root_packages. (Prior to this, you could only pass the portion.)