Skip to content

Add the "UP" (pyupgrade) ruff rules #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seddonym merged 2 commits into from
Dec 17, 2025
Merged

Add the "UP" (pyupgrade) ruff rules #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c352226
Enable "UP" rules in Ruff (pyupgrade)
nathanjmcdougall Dec 16, 2025
bad9b00
Merge remote-tracking branch 'upstream/main' into refactor/enable-ruf…
nathanjmcdougall Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,5 @@ namespaces = false
[tool.ruff]
line-length = 99
exclude = ['tests/assets'] # These are sample packages for tests to run under - we don't want ruff to mess with them.
[tool.ruff.lint]
select = ["E4", "E7", "E9", "F", "UP"]
Copy link
Contributor Author

@nathanjmcdougall nathanjmcdougall Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These other rules are the defaults

https://docs.astral.sh/ruff/configuration/#configuring-ruff

3 changes: 1 addition & 2 deletions src/grimp/adaptors/caching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import json
import logging
from typing import Optional

from grimp.application.ports.filesystem import BasicFileSystem
from grimp.application.ports.modulefinder import FoundPackage, ModuleFile
Expand All @@ -13,7 +12,7 @@
from grimp import _rustgrimp as rust # type: ignore[attr-defined]

logger = logging.getLogger(__name__)
PrimitiveFormat = dict[str, list[tuple[str, Optional[int], str]]]
PrimitiveFormat = dict[str, list[tuple[str, int | None, str]]]


class CacheFileNamer:
Expand Down