Skip to content

Conversation

@nathanjmcdougall
Copy link
Contributor

@nathanjmcdougall nathanjmcdougall commented Dec 16, 2025

[ ] Add tests for the change. In general, aim for full test coverage at the Python level. Rust tests are optional.
[ ] Add any appropriate documentation.
[ ] Add a summary of changes to CHANGELOG.rst.
[ ] Add your name to AUTHORS.rst.
[ ] Run just full-check.

This is a follow-up to enabling Powershell support in #277.

Due to inconsistencies in shell behaviours with echo commands, the using unquoted echo is not properly supported by Powershell. It will pause and wait for user input:

cmdlet Write-Output at command pipeline position 1
Supply values for the following parameters:
InputObject[0]:

This is a follow-up to enabling Powershell support, to prevent hanging/waiting for user input:

```
cmdlet Write-Output at command pipeline position 1
Supply values for the following parameters:
InputObject[0]:
```
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 16, 2025

CodSpeed Performance Report

Merging #283 will not alter performance

Comparing nathanjmcdougall:fix/use-quoted-echo-calls (6c3fb81) with main (f397742)

Summary

✅ 26 untouched
⏩ 23 skipped1

Footnotes

  1. 23 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@seddonym seddonym merged commit 5c2bcf4 into python-grimp:main Dec 17, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants