feat(ci): introduce pylint checker #1499
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1499 +/- ##
==========================================
+ Coverage 78.98% 78.99% +0.01%
==========================================
Files 354 354
Lines 11518 11514 -4
Branches 531 530 -1
==========================================
- Hits 9098 9096 -2
+ Misses 2237 2236 -1
+ Partials 183 182 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request introduces pylint as a code quality checker to the CI pipeline. The changes include configuring pylint with appropriate rules, adding a GitHub Actions workflow to run it, and making numerous code improvements to satisfy pylint's requirements.
Key changes:
- Added pylint 4.0.4 as a development dependency with comprehensive configuration
- Created a new GitHub Actions workflow for automated pylint checking
- Refactored code throughout the codebase to improve code quality (f-string conversions, exception chaining, control flow simplifications)
Reviewed changes
Copilot reviewed 97 out of 97 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/pylint.yml |
New workflow file to run pylint checks on pushes and pull requests |
pyproject.toml |
Added pylint dependency, configuration with disabled rules, and removed B904/TRY301 from ruff ignore list |
social_core/utils.py |
Modernized string formatting, improved exception chaining, simplified control flow |
social_core/storage.py |
Added pylint disable comment for redefined-builtin |
social_core/pipeline/social_auth.py |
Added pylint disable comment, simplified else-block |
social_core/pipeline/disconnect.py |
Fixed variable shadowing issue by renaming variable |
social_core/tests/models.py |
Added pylint disable comment for redefined-builtin |
social_core/tests/test_*.py |
Added return type annotations to test methods |
social_core/tests/backends/base.py |
Removed unused import |
social_core/tests/actions/actions.py |
Converted string concatenation to f-strings |
social_core/backends/*.py |
Extensive refactoring: f-string conversions, exception chaining, control flow improvements, method refactoring |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes pylint inconsistent-return-statements and no-else-return.
Fixes pylint reimported and unused-import.
Fixes pylint pointless-string-statement.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 100 out of 100 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| search for "little bit different way" | ||
| """ | ||
| suffix = odnoklassniki_sig("{:s}{:s}".format(data["access_token"], client_secret)) | ||
| suffix = odnoklassniki_sig(f"{data['access_token']:s}{client_secret:s}") |
There was a problem hiding this comment.
The format specifier :s is unnecessary in f-strings for string values. The access_token and client_secret variables are already strings, so the :s suffix is redundant and should be removed for cleaner code.
nijel
force-pushed
the
pylint
branch
2 times, most recently
from
8d8b5b7 to
c035f07
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 100 out of 100 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes pylint undefined-loop-variable and possibly-used-before-assignment.
Fixes pylint useless-parent-delegation.
Fixes pylint redefined-outer-name.
- store it in a class attribute - allow to override store in backend - fixes pylint attribute-defined-outside-init
- remove unneded ones (where generic implementation was improved since then) - fix passed parameters ordering - fixed return types - fixes pylint arguments-renamed - fixes pyright reportIncompatibleMethodOverride
This avoids project wide exception keeping the current code as is (it would need deep investigation which I cannot perform now).
Fixes pylint no-else-raise.
Fixes pylint raise-missing-from and ruff B904.
This makes the code more readable without deep nesting, fixes pylint too-many-nested-blocks.
This is currently part of our API, so we can hardly change it.
- This makes the code more readable. - Fixes pylint consider-using-f-string.
It was previously used by qiita, but manually encoded.
1 participant
No description provided.