Skip to content

GH-136155: Fail the EPUB check on fatal errors #137351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 8, 2025

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Aug 3, 2025

We also split epub to a parallel job.

A


📚 Documentation preview 📚: https://cpython-previews--137351.org.readthedocs.build/

@hugovk
Copy link
Member

hugovk commented Aug 3, 2025

We also split epub to a parallel job.

The original PR had these as parallel jobs, but I asked to keep them in the same one because they have a lot of duplicate setup config :)

#134074 (comment)

@AA-Turner
Copy link
Member Author

True, though the setup for epub alone is far simpler & easier to comprehend. I think splitting is useful, without doing so the docs job takes ~2 minutes longer, which delays feedback if the PR is good to leave as-is. It's rare for doctest to fail & docs to pass.

A

@AA-Turner AA-Turner merged commit b4a1974 into python:main Aug 8, 2025
42 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Aug 8, 2025
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @AA-Turner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b4a1974aa2af63c4754846af9abfb436372e19c7 3.14

@miss-islington-app
Copy link

Sorry, @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b4a1974aa2af63c4754846af9abfb436372e19c7 3.13

@AA-Turner AA-Turner deleted the docs/epub-strict branch August 8, 2025 01:32
@AA-Turner
Copy link
Member Author

AA-Turner commented Aug 8, 2025

I've cherry-picked this commit into #137538 & #137539.

AA-Turner added a commit to miss-islington/cpython that referenced this pull request Aug 8, 2025
AA-Turner added a commit to miss-islington/cpython that referenced this pull request Aug 8, 2025
@AA-Turner AA-Turner removed the needs backport to 3.13 bugs and security fixes label Aug 8, 2025
@AA-Turner AA-Turner removed the needs backport to 3.14 bugs and security fixes label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants