-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
GH-136155: Fail the EPUB check on fatal errors #137351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The original PR had these as parallel jobs, but I asked to keep them in the same one because they have a lot of duplicate setup config :) |
True, though the setup for epub alone is far simpler & easier to comprehend. I think splitting is useful, without doing so the docs job takes ~2 minutes longer, which delays feedback if the PR is good to leave as-is. It's rare for doctest to fail & docs to pass. A |
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, @AA-Turner, I could not cleanly backport this to
|
Sorry, @AA-Turner, I could not cleanly backport this to
|
We also split
epub
to a parallel job.A
📚 Documentation preview 📚: https://cpython-previews--137351.org.readthedocs.build/