gh-139320: Cover exception chaining in the docs of contextmanager.__exit__
#140169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ZeroIntensity (mentorship) can we request a review on this? |
Member
|
Sorry for the delay. Could you reword this to include a link to |
Contributor
Author
|
@encukou Thanks! Done. |
Member
|
Thank you! |
encukou
added
needs backport to 3.13
|
Thanks @johnslavik for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @johnslavik for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 16, 2025
…ger.__exit__` (pythonGH-140169) (cherry picked from commit a44509e) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 16, 2025
…ger.__exit__` (pythonGH-140169) (cherry picked from commit a44509e) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
|
GH-142792 is a backport of this pull request to the 3.14 branch. |
|
GH-142793 is a backport of this pull request to the 3.13 branch. |
encukou
pushed a commit
that referenced
this pull request
Dec 17, 2025
encukou
pushed a commit
that referenced
this pull request
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip news.
__exit__exception behavior wording is incomplete #139320📚 Documentation preview 📚: https://cpython-previews--140169.org.readthedocs.build/