-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-139588: Docs: Convert the execution model "textual" diagram to a visual diagram #140721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-139588: Docs: Convert the execution model "textual" diagram to a visual diagram #140721
Conversation
|
Note that the error has now been fixed by the other PR. |
StanFromIreland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work with translations? Is it extracted by the gettext builder?
|
gettext builder extracts the current text for translation, but the product of this pull request is not extracted for translation. (just tested) |
|
Thanks for testing, Rafael. As such, I am -0 on this, although we could keep the textual ones just for translations (instead of the graphic) using the |
|
The best would be to have this graphic but the labels translated, but I don't even know if it is possible. |
|
It also breaks on EPUB: |
What exactly command did you use to get this? And what SO? I've tried on Ubuntu, but I didn't get this warning or any other indication that the build will fail. However, the generated EPUB file is broken. |
It prevents LaTeX PDF build error: Too deeply nested. (Regression from #139509.).
Besides, it also makes the diagram richer.
It is an alternative to #140709.
#139588: Docs: Convert the execution model "textual" diagram to a visual diagram
📚 Documentation preview 📚: https://cpython-previews--140721.org.readthedocs.build/