Skip to content

gh-129824: Fix data race on runtime->gilstate.check_enabled #143530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 2 commits into from
Jan 7, 2026
Merged

gh-129824: Fix data race on runtime->gilstate.check_enabled #143530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b04003c
gh-129824: Fix data race on runtime->gilstate.check_enabled
colesbury Jan 7, 2026
bb7c984
Use atomic for read as well
colesbury Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Python/pylifecycle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2435,7 +2435,7 @@ new_interpreter(PyThreadState **tstate_p,

/* Issue #10915, #15751: The GIL API doesn't work with multiple
interpreters: disable PyGILState_Check(). */
runtime->gilstate.check_enabled = 0;
_Py_atomic_store_int_relaxed(&runtime->gilstate.check_enabled, 0);

// XXX Might new_interpreter() have been called without the GIL held?
PyThreadState *save_tstate = _PyThreadState_GET();
Expand Down
2 changes: 1 addition & 1 deletion Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2832,7 +2832,7 @@ int
PyGILState_Check(void)
{
_PyRuntimeState *runtime = &_PyRuntime;
if (!runtime->gilstate.check_enabled) {
if (!_Py_atomic_load_int_relaxed(&runtime->gilstate.check_enabled)) {
return 1;
}

Expand Down
Loading