GH-143493: Conform to spec for generator expressions while supporting virtual iterators #143569
Conversation
…erators * Moves the `GET_ITER` instruction into the generator function preamble. This means the the iterable is converted into an iterator during generator creation, as documented, but keeps it in the same code object allowing optimization.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Sorry, the code was changed so much since I worked with it, that I can no longer make qualified review. I can understand particular changes, but I cannot catch if something was missed. The original idea looks reasonably.
BTW, what happens when __iter__() raises StopIteration?
Is similar change needed for asynchronous generators?
The exception is raised before the generator is created and the traceback shows the iterable as the location of the exception. |
I don't think asynchronous generators were ever changed, so they still have the old behavior from 3.13 and earlier. |
3 participants
GET_ITERinstruction into the generator function preamble. This means the the iterable is converted into an iterator during generator creation, as documented, but keeps it in the same code object allowing optimization.