Skip to content

gh-143663: Perform path normalization in TarFile.extractall() #143665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xd6cb6d73 wants to merge 9 commits into
base: main
Choose a base branch
from
+2 −1
Open

gh-143663: Perform path normalization in TarFile.extractall() #143665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
75b6685
Perform path normalization in TarFile.extractall()
0xd6cb6d73 Jan 10, 2026
c48bda8
Fix blurb syntax
0xd6cb6d73 Jan 10, 2026
765776a
Do not systematically normalize path in extractall
0xd6cb6d73 Jan 10, 2026
d41ed21
Replace tar separator by OS-specific separator in _get_extract_tarinfo
0xd6cb6d73 Jan 10, 2026
4776a7c
Update NEWS entry
0xd6cb6d73 Jan 10, 2026
d84c7bc
Only perform separator replacement if platform separator doesn't matc…
0xd6cb6d73 Jan 12, 2026
4621b22
Improve separator replacement
0xd6cb6d73 Jan 12, 2026
9d94cc9
Only perform path separator replacement at lstat callsite
0xd6cb6d73 Jan 12, 2026
88fc915
Update blurb
0xd6cb6d73 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/tarfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2438,7 +2438,7 @@ def extractall(self, path=".", members=None, *, numeric_owner=False,
continue
dirpath = os.path.join(path, tarinfo.name)
try:
lstat = os.lstat(dirpath)
lstat = os.lstat(dirpath.replace(r'/', os.sep))
except FileNotFoundError:
self._log_no_directory_fixup(tarinfo, 'missing')
continue
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2026-01-10-17-39-09.gh-issue-143663.9LEFAf.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
:mod:`tarfile`: :meth:`TarFile.extractall` now uses OS-specific separators to call lstat. This fixes a failure case with raw Win32 paths on Windows.
Loading