gh-143674: Document F/D complex format characters in struct module #143675
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation for the F (complex from two floats) and D (complex from two doubles) format characters in the struct module docstring. These format characters were implemented but not documented.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
Are you using generative AI for this pr? |
Author
Yep I use it for commit message and comment |
skirpichev
reviewed
Jan 11, 2026
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
skirpichev
approved these changes
Jan 11, 2026
Member
|
Reported @quanghuynh10111-lab to GitHub. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143674
Changes
F(complex from two floats) andD(complex from two doubles) format characters to the struct module docstringRationale
These format characters are implemented in the struct module (lines 858-859, 1189-1190, 1504-1505 in Modules/_struct.c) but were missing from the module's docstring documentation. Users consulting the docstring with
help(struct)would not know these options exist.Testing
Checklist