gh-143811: Add helpful default error messages to AttributeError and NameError
#143813
Conversation
| wrong_name = getattr(exc_value, "name", None) | ||
| if wrong_name is not None and wrong_name in sys.stdlib_module_names: |
There was a problem hiding this comment.
Out of scope, within the same function: wrong_name = ... and wrong_name is not None and could be removed here.
| elif exc_type and issubclass(exc_type, (NameError, AttributeError)) and \ | ||
| getattr(exc_value, "name", None) is not None: | ||
| wrong_name = getattr(exc_value, "name", None) | ||
| (wrong_name := getattr(exc_value, "name", None)) is not None: |
There was a problem hiding this comment.
This semantic change reduces the possibility of wrong_name being None completely. I'm convinced that this was the original intent of the author.
There was a problem hiding this comment.
This all looks good to me. I think you're right about the original intent. Likely they wanted to check if the attribute name exists on the exception, and only then proceed with formatting suggestions.
| obj_type_name = object.__getattribute__(obj_type, "__name__") | ||
| self._str = f"{obj_type_name!r} object has no attribute {wrong_name!r}" | ||
| else: # NameError | ||
| self._str = repr(wrong_name) |
There was a problem hiding this comment.
For consistency with the existing error patterns should we change this to self._str = f"name {wrong_name!r} is not defined" ?
There was a problem hiding this comment.
Yes! I've missed it, thanks. Good idea. I'll fix it.
2 participants
AttributeErrorin__getattr__shows a garbled message with attribute suggestions #143811CC @a12k for review