Add tests and fix ReleaseDriver serialization #316
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shelve database was storing full Task objects which contain function references. This caused pickling errors when tasks were defined as local functions in tests. Storing just the description strings avoids the serialization issue while preserving all resume functionality. Also fixes the cd() context manager to use try/finally, ensuring the working directory is restored even when exceptions occur.
The completed_tasks field now stores task description strings rather than Task objects, so the Protocol type hints need to match. This keeps mypy happy after the ReleaseDriver serialization change.
Tests cover SSH helpers, ReleaseState, ReleaseDriver, retry logic, and server upload functions. Uses GIVEN/WHEN/THEN comments to structure test phases. The tests focus on verifying behavior through mocked SSH/SFTP operations since the actual servers aren't available in CI.
pablogsal
changed the title
Member
Author
|
Damn, i need to update this branch with the new test suite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.