Skip to content

Fix type annotation with two string literals #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix type annotation with two string literals #1853

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3269d07
Fix type annotation with two string literals
Glyphack Sep 3, 2024
6555cfd
Update conformance/tests/annotations_forward_refs.py
Glyphack Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conformance/tests/annotations_forward_refs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class ClassA:
# The following should all generate errors because they are not legal type
# expressions, despite being enclosed in quotes.
def invalid_annotations(
p1: "eval(" ".join(map(chr, [105, 110, 116])))", # E
p1: "eval(''.join(map(chr, [105, 110, 116])))", # E
p2: "[int, str]", # E
p3: "(int, str)", # E
p4: "[int for i in range(1)]", # E
Expand Down