Skip to content

Conversation

@jcaip
Copy link
Contributor

@jcaip jcaip commented Nov 6, 2025

att

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3298

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4e382e2 with merge base 6815e57 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2025
@jcaip jcaip added topic: bug fix Use this tag for PRs that fix bugs topic: not user facing Use this tag if you don't want this PR to show up in release notes labels Nov 6, 2025
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg if it doesn't break the module parameters path

Comment on lines +1141 to +1142
"nested.linear": Int8WeightOnlyConfig(),
"linear1": Int8WeightOnlyConfig(),
Copy link
Contributor

@jerryzh168 jerryzh168 Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use new tensors, e.g. Int4WeightOnlyConfig (with Int4Tensor), since we are moving away from AQT

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is missed I think @jcaip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry didn't see this - let me update all of the configs in the tests

@jcaip jcaip merged commit 0c081fd into main Nov 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: bug fix Use this tag for PRs that fix bugs topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants