Create im2row hifi cpp kernel tests #15123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonglinpeng
requested review from
kirklandsign and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15123
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit db0161d with merge base 1a5eaec ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@zonglinpeng has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84639802. |
This PR needs a
|
Summary: im2row HiFi optimizations Pull Request resolved: pytorch#13431 Test Plan: unit tests Differential Revision: D82218005 Pulled By: zonglinpeng
Differential Revision: D84639743
zonglinpeng
force-pushed
the
export-D84639802
branch
from
0e94abd to
33d7cb7
Compare
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Oct 14, 2025
Summary: Pull Request resolved: pytorch#15123 ### Summary This diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend. The test is added in the `test_op_im2row_out.cpp` file and is compilable on both fbcode and xplat. The test includes a new function `im2row_out` in the `operators.h` file, which is declared but not defined. The definition of this function is not provided in this diff. The test file `test_op_im2row_out.cpp` includes the necessary headers and uses the `gtest` framework for testing. It also includes some utility functions from the `executorch` library. Overall, this diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend, but does not provide the implementation of the operator itself. Differential Revision: D84639802
mcremon-meta
approved these changes
Oct 14, 2025
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Oct 14, 2025
Summary: Pull Request resolved: pytorch#15123 ### Summary This diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend. The test is added in the `test_op_im2row_out.cpp` file and is compilable on both fbcode and xplat. The test includes a new function `im2row_out` in the `operators.h` file, which is declared but not defined. The definition of this function is not provided in this diff. The test file `test_op_im2row_out.cpp` includes the necessary headers and uses the `gtest` framework for testing. It also includes some utility functions from the `executorch` library. Overall, this diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend, but does not provide the implementation of the operator itself. Reviewed By: mcremon-meta Differential Revision: D84639802
zonglinpeng
force-pushed
the
export-D84639802
branch
from
33d7cb7 to
43f5a07
Compare
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Oct 14, 2025
Summary: Pull Request resolved: pytorch#15123 ### Summary This diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend. The test is added in the `test_op_im2row_out.cpp` file and is compilable on both fbcode and xplat. The test includes a new function `im2row_out` in the `operators.h` file, which is declared but not defined. The definition of this function is not provided in this diff. The test file `test_op_im2row_out.cpp` includes the necessary headers and uses the `gtest` framework for testing. It also includes some utility functions from the `executorch` library. Overall, this diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend, but does not provide the implementation of the operator itself. Reviewed By: mcremon-meta Differential Revision: D84639802
zonglinpeng
force-pushed
the
export-D84639802
branch
from
43f5a07 to
6529a90
Compare
Summary: Pull Request resolved: pytorch#15123 ### Summary This diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend. The test is added in the `test_op_im2row_out.cpp` file and is compilable on both fbcode and xplat. The test includes a new function `im2row_out` in the `operators.h` file, which is declared but not defined. The definition of this function is not provided in this diff. The test file `test_op_im2row_out.cpp` includes the necessary headers and uses the `gtest` framework for testing. It also includes some utility functions from the `executorch` library. Overall, this diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend, but does not provide the implementation of the operator itself. Reviewed By: mcremon-meta Differential Revision: D84639802
zonglinpeng
force-pushed
the
export-D84639802
branch
from
6529a90 to
db0161d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
This diff adds a new test for the
im2row_outoperator in the Cadence HiFi backend. The test is added in thetest_op_im2row_out.cppfile and is compilable on both fbcode and xplat.The test includes a new function
im2row_outin theoperators.hfile, which is declared but not defined. The definition of this function is not provided in this diff.The test file
test_op_im2row_out.cppincludes the necessary headers and uses thegtestframework for testing. It also includes some utility functions from theexecutorchlibrary.Overall, this diff adds a new test for the
im2row_outoperator in the Cadence HiFi backend, but does not provide the implementation of the operator itself.Differential Revision: D84639802