-
Notifications
You must be signed in to change notification settings - Fork 795
Qualcomm AI Engine Direct - fix optrace demo script and remove redundant flags from QNN tool #16487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qualcomm AI Engine Direct - fix optrace demo script and remove redundant flags from QNN tool #16487
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16487
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 1 Unrelated FailureAs of commit c1af223 with merge base 913436a ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @cccclai, The This change fixes the demo script by using the correct input type and Please have a look! |
|
@pytorchbot label "release notes: qualcomm" |
| ) | ||
|
|
||
|
|
||
| def main(args) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have tests for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out!
We already have a test covering this test here:
https://github.com/pytorch/executorch/blob/main/backends/qualcomm/tests/test_qnn_delegate.py#L8176
In one of the earlier changes, this test was already failing in internal CI, but that failure wasn’t noticed at that time.
It’s now passing and can be used as expected.
…ant flags from QNN tool
366916a to
c1af223
Compare
Qualcomm AI Engine Direct - Fix OpTrace Profiling demo script
Summary
Test plan
python -m examples.qualcomm.util_scripts.qairt_visualizer_demo -s {SERIAL_NUM} -m ${SOC_MODEL} -b build-android -a ${path_to_output_folder}python -m examples.qualcomm.util_scripts.qairt_visualizer_demo -s {SERIAL_NUM} -m ${SOC_MODEL} -b build-android -a ${path_to_output_folder} --online_preparepython -m backends.qualcomm.tests.test_qnn_delegate.TestUtilsScript.test_debugger_generate_optrace -s {SERIAL_NUM} -m ${SOC_MODEL} -b build-android --executorch_root . -a .