[Feature,Quality] Raise ValueError if split_size is zero #1480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation to prevent split_size from being zero.
Description
Add validation to prevent split_size from being zero, which then causes CPU OOM.
Motivation and Context
Why is this change required? What problem does it solve?
verl gets CPU OOM killed when
ppo_micro_batch_size < world_sizeindata.batch.split(ppo_micro_batch_size//world_size). That is, when TensorDict.split gets an 0 int input.Fixes #1479.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!