Make 'default' timezone deterministic in ConverterTest #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnorth
force-pushed
the
deterministic-tz-in-test
branch
from
7036eac to
e20df78
Compare
Also add `@Test` annotation to `testLineLocalPortConverter` method, which looks like it was accidentally omitted. Signed-off-by: Richard North <rich.north@gmail.com>
rnorth
force-pushed
the
deterministic-tz-in-test
branch
from
e20df78 to
c7bde82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests locally,
ConverterTest.testDateConverterwas failing for me. It seems like the test would only pass when run in a UTC+2h timezone (setting theTZenv var confirms).I've added an override for the JVM timezone during the particular test case in question, which enables the test to pass regardless of the contributor's location.
I also added
@Testannotation totestLineLocalPortConvertermethod, which looked like it was accidentally omitted.