Skip to content

Conversation

alesj
Copy link
Contributor

@alesj alesj commented Jul 21, 2025

This way a user can fix the LGTM ports, to always be the same.
See issue #46993.

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Jul 21, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

This comment has been minimized.

@brunobat
Copy link
Contributor

For some reason this test continues to fail io.quarkus.it.opentelemetry.grpc.HelloGrpcClientTest.testHello

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@alesj
Copy link
Contributor Author

alesj commented Jul 28, 2025

@brunobat HelloGrpcClientTest passes for me locally -- the changes should not affect it

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@brunobat
Copy link
Contributor

brunobat commented Aug 4, 2025

This is still failing, @alesj. Let's debug it tomorrow on our meeting.

✖ io.quarkus.it.opentelemetry.grpc.HelloGrpcClientTest.testHello - History

This comment has been minimized.

This comment has been minimized.


public abstract class AbstractGrafanaConfig extends AbstractContainerConfig implements GrafanaConfig {

private final String username;
private final String password;
private final int grafanaPort;
private final Optional<Integer> grafanaPort;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use OptionalInt instead

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually started a service with the grafana-lgtm and the following configs:

quarkus.observability.lgtm.grafana-port=3001
quarkus.observability.lgtm.otel-grpc-port=5317
quarkus.observability.lgtm.otel-http-port=5318

Got this log line on startup:
2025-08-06 17:20:42,890 INFO [org.tes.con.wai.str.HttpWaitStrategy] (ducttape-0) /ecstatic_newton: Waiting for 180 seconds for URL: http://localhost:32784/ (where port 32784 maps to container port 3001)

After the 180 seconds, docker container fails to start.

@alesj
Copy link
Contributor Author

alesj commented Aug 7, 2025

Manually started a service with the grafana-lgtm and the following configs:

quarkus.observability.lgtm.grafana-port=3001
quarkus.observability.lgtm.otel-grpc-port=5317
quarkus.observability.lgtm.otel-http-port=5318

Got this log line on startup: 2025-08-06 17:20:42,890 INFO [org.tes.con.wai.str.HttpWaitStrategy] (ducttape-0) /ecstatic_newton: Waiting for 180 seconds for URL: http://localhost:32784/ (where port 32784 maps to container port 3001)

After the 180 seconds, docker container fails to start.

This is strange, as it should always map to 3000 -- which is where the Grafana is running "internally".
And no idea why your fixed port of 3001 is not used.

When I run the "fixed" ports module / dir, it looks OK

2025-08-07 11:42:10,627 INFO [org.tes.con.wai.str.HttpWaitStrategy] (ducttape-0) /great_solomon: Waiting for 180 seconds for URL: http://localhost:3001/ (where port 3001 maps to container port 3000)

As expected ...

This comment has been minimized.

This comment has been minimized.

@brunobat
Copy link
Contributor

brunobat commented Aug 7, 2025

I took

quarkus.observability.lgtm.grafana-port=3001
quarkus.observability.lgtm.otel-grpc-port=5317
quarkus.observability.lgtm.otel-http-port=5318

from the documentation on the PR.

I think "support fixed lgtm ports" must be clarified. Is this to support user side fixed ports or container side?
If it's user side, quarkus.observability.lgtm.grafana-port=3001 should have been mapped to the correct container port.

@alesj
Copy link
Contributor Author

alesj commented Aug 11, 2025

I think "support fixed lgtm ports" must be clarified. Is this to support user side fixed ports or container side?

It's users, since I doubt we can change the container side -- those are "baked" into the image; unless there is some configuration option to change them.

If it's user side, quarkus.observability.lgtm.grafana-port=3001 should have been mapped to the correct container port.

Yeah, that's the weird part about your output -- you seem to get random user port, mapped to 3001 container port.
Where it should be as I get it -- 3001 maps to 3000.

@alesj
Copy link
Contributor Author

alesj commented Aug 11, 2025

I think "support fixed lgtm ports" must be clarified

I've added a bit more about this to the docs.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@holly-cummins
Copy link
Contributor

holly-cummins commented Aug 11, 2025

Note that this will suffer from port conflicts in the case where a user has a couple of profiles which use the same port. That doesn't mean we shouldn't do it, it's just something to be aware of. The problem will go away when LGTM is moved to the new dev services model.

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it again. It works for me now.

Copy link

quarkus-bot bot commented Aug 26, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit e9fc7da.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Aug 26, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e9fc7da.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

io.quarkus.gradle.BuildConfigurationTest.buildNoOverride - History

  • Multiple Failures (1 failure) -- failure 1 -- [sub project 'without-configuration', package type 'fast-jar'] Expecting path: - org.assertj.core.error.AssertJMultipleFailuresError
org.assertj.core.error.AssertJMultipleFailuresError: 

Multiple Failures (1 failure)
-- failure 1 --
[sub project 'without-configuration', package type 'fast-jar'] 
Expecting path:
  D:\a\quarkus\quarkus\integration-tests\gradle\target\classes\build-configuration\without-configuration\build\quarkus-app\quarkus-run.jar
to exist (symbolic links were followed).

@brunobat
Copy link
Contributor

Did a manual test drive and it worked as expected now.

@brunobat brunobat merged commit a3b002c into quarkusio:main Aug 26, 2025
58 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.28 - main milestone Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants