-
Notifications
You must be signed in to change notification settings - Fork 3k
Support fixed LGTM ports #49007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fixed LGTM ports #49007
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
For some reason this test continues to fail |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@brunobat HelloGrpcClientTest passes for me locally -- the changes should not affect it |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
||
public abstract class AbstractGrafanaConfig extends AbstractContainerConfig implements GrafanaConfig { | ||
|
||
private final String username; | ||
private final String password; | ||
private final int grafanaPort; | ||
private final Optional<Integer> grafanaPort; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use OptionalInt
instead
...lity-devservices/common/src/main/java/io/quarkus/observability/common/config/LgtmConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually started a service with the grafana-lgtm and the following configs:
quarkus.observability.lgtm.grafana-port=3001
quarkus.observability.lgtm.otel-grpc-port=5317
quarkus.observability.lgtm.otel-http-port=5318
Got this log line on startup:
2025-08-06 17:20:42,890 INFO [org.tes.con.wai.str.HttpWaitStrategy] (ducttape-0) /ecstatic_newton: Waiting for 180 seconds for URL: http://localhost:32784/ (where port 32784 maps to container port 3001)
After the 180 seconds, docker container fails to start.
This is strange, as it should always map to 3000 -- which is where the Grafana is running "internally". When I run the "fixed" ports module / dir, it looks OK
As expected ... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I took
from the documentation on the PR. I think "support fixed lgtm ports" must be clarified. Is this to support user side fixed ports or container side? |
It's users, since I doubt we can change the container side -- those are "baked" into the image; unless there is some configuration option to change them.
Yeah, that's the weird part about your output -- you seem to get random user port, mapped to 3001 container port. |
I've added a bit more about this to the docs. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Note that this will suffer from port conflicts in the case where a user has a couple of profiles which use the same port. That doesn't mean we shouldn't do it, it's just something to be aware of. The problem will go away when LGTM is moved to the new dev services model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it again. It works for me now.
Status for workflow
|
Status for workflow
|
Did a manual test drive and it worked as expected now. |
This way a user can fix the LGTM ports, to always be the same.
See issue #46993.