Skip to content

Add support for Hibernate's hibernate.hbm2ddl.extra_physical_table_types #49063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for Hibernate's hibernate.hbm2ddl.extra_physical_table_types #49063

wants to merge 1 commit into from

Conversation

Chu3laMan
Copy link

@Chu3laMan Chu3laMan commented Jul 23, 2025 •
edited by geoand
Loading

This MR adds support for configuring additional database object types to be included
in schema management operations, such as materialized views or other database-specific objects.

Changes:

Add documentation for the existing extraPhysicalTableTypes() method
Pass the configuration to Hibernate ORM in FastBootHibernatePersistenceProvider
Add the same implementation for Hibernate Reactive in FastBootHibernateReactivePersistenceProvider
Define a constant for the setting if not already available in Hibernate's AvailableSettings

Example usage: quarkus.hibernate-orm.extra-physical-table-types=MATERIALIZED VIEW,VIEW

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 23, 2025

/cc @gsmet (hibernate-orm)

@Chu3laMan
Copy link
Author

Hi @geoand, I already closed the first one and opened this new PR

@geoand geoand mentioned this pull request Jul 23, 2025
Closed
@geoand
Copy link
Contributor

geoand commented Jul 23, 2025

Thanks. This PR still contains merge commits. You'll need to rebase your branch onto main and then force push it

@yrodiere
Copy link
Member

I'll do the rebase, let's not get to the same situation as before :)

@geoand
Copy link
Contributor

geoand commented Jul 23, 2025

The problem is that @Chu3laMan will need to make sure not to use their branch, but the updated one only

@yrodiere yrodiere force-pushed the feature/47854-Add-a-supported-configuration-property-v2 branch from 2e5c076 to 50e5982 Compare July 23, 2025 09:04
yrodiere
yrodiere requested changes Jul 23, 2025
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some unrelated changes crept in.

IMPORTANT: I rebased your branch and force-pushed. Please run git pull before resuming work on your local clone.

core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingResourceProcessor.java
Comment on lines +567 to +578
@BuildStep
@Produce(ServiceStartBuildItem.class)
void closeBuildTimeLogging(List<DevServicesResultBuildItem> devServices) {
if (devServices.isEmpty()) {
((QuarkusClassLoader) Thread.currentThread().getContextClassLoader()).addCloseTask(new Runnable() {
@Override
public void run() {
InitialConfigurator.DELAYED_HANDLER.buildTimeComplete();
}
});
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this related? 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's building at the Initial JDK 17 job, It highlighted an error there when I checked that class I found there is a method duplicated which is

void closeBuildTimeLogging(List devServices)

`
@Mac quarkus % grep -n "closeBuildTimeLogging" core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingResourceProcessor.java
343: // When there is no devservices build time logging is still closed at deployment classloader close #closeBuildTimeLogging
556: void closeBuildTimeLogging(List devServices) {
569: void closeBuildTimeLogging(List devServices) {

`

core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java
Comment on lines -680 to -686
// Cache implementation types of nested elements
List<ConfigMappingMetadata> configMappingsMetadata = ConfigMappingLoader
.getConfigMappingsMetadata(mapping.getType());
for (ConfigMappingMetadata configMappingMetadata : configMappingsMetadata) {
clinit.invokeStaticMethod(ENSURE_LOADED, clinit.load(configMappingMetadata.getInterfaceType().getName()));
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, changes in this file seem unrelated.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 23, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 50e5982.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✖ Initial JDK 17 Build Build Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ Initial JDK 17 Build #

- Failing: core/deployment 
! Skipped: devtools/bom-descriptor-json devtools/cli devtools/gradle/gradle-application-plugin and 878 more

📦 core/deployment

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project quarkus-core-deployment: Compilation failure /home/runner/_work/quarkus/quarkus/core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingResourceProcessor.java:[569,10] method closeBuildTimeLogging(java.util.List<io.quarkus.deployment.builditem.DevServicesResultBuildItem>) is already defined in class io.quarkus.deployment.logging.LoggingResourceProcessor

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 23, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 50e5982.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✖ Documentation Build Build Failures Logs Raw logs 🚧

Failures

⚙️ Documentation Build #

- Failing: core/deployment 
! Skipped: core/junit4-mock devtools/bom-descriptor-json devtools/cli and 1227 more

📦 core/deployment

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project quarkus-core-deployment: Compilation failure /home/runner/work/quarkus/quarkus/core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingResourceProcessor.java:[569,10] method closeBuildTimeLogging(java.util.List<io.quarkus.deployment.builditem.DevServicesResultBuildItem>) is already defined in class io.quarkus.deployment.logging.LoggingResourceProcessor

@geoand
Copy link
Contributor

geoand commented Jul 29, 2025

@Chu3laMan do you plan to push this one over the finish line?

@cescoffier
Copy link
Member

@Chu3laMan ping?

@Chu3laMan
Copy link
Author

@Chu3laMan ping?

Sorry for being late to reply back, I have done a cherry-pick to surpass the conflict however still getting the same issue.

@cescoffier
Copy link
Member

Try to rebase on a clean branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/core area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a supported configuration property "hibernate.hbm2ddl.extra_physical_table_types"
4 participants
@Chu3laMan @geoand @yrodiere @cescoffier