Make sure query params are correct when set from ContainerRequestFilter #49065
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
geoand
commented
Jul 23, 2025
geoand
commented
- Fixes: UriInfo.getRequestUri loses query parameters if ContainerRequestContext.setRequestUri is called #49064
gsmet
approved these changes
Jul 23, 2025
gsmet
added
the
triage/waiting-for-ci
FroMage
reviewed
Jul 23, 2025
|
|
Status for workflow
|
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
FroMage
approved these changes
Jul 23, 2025
| builder.replacePath("/hello"); | ||
| UriInfo originalUriInfo = requestContext.getUriInfo(); | ||
| UriBuilder builder = originalUriInfo.getRequestUriBuilder(); | ||
| builder.replacePath(originalUriInfo.getPath().contains("2") ? "/hello/2" : "/hello"); |
There was a problem hiding this comment.
OH OK I see. I was thinking it's replacePath that we need to check, thinking this is where the original reporter added a path that included query parameters that we dropped.
But in fact we're using the builder to build a URI, which includes query parameters, and then later down we call setRequestUri with query param (that was the original bug).
I got confused, this is fine, thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.