refactor: apply new login screen design #501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies a comprehensive redesign to the login screen, introducing a modernized visual design with improved error handling and user feedback mechanisms.
Key changes:
- Redesigned login UI with new visual elements (background images, custom fonts, updated styling)
- Enhanced error handling by consolidating error states into the login view instead of a separate error page
- Improved error messaging with clearer, more actionable feedback for authentication failures
Reviewed changes
Copilot reviewed 10 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/styled.d.ts | Added loginBackground color to theme type definition |
| src/theme/index.ts | Added dark login background color value |
| src/providers/SettingsProvider/index.tsx | Updated error view with new design elements and improved error messaging |
| src/providers/AuthProvider.tsx | Refactored logout function to accept error parameters; removed separate error view |
| src/modules/OAuth2/views/login.tsx | Complete login screen redesign with new layout, styling, and error display |
| src/modules/OAuth2/views/error.tsx | Removed separate error view component |
| src/components/Form/FormItem/index.tsx | Added error icon and updated error message styling |
| src/components/Form/FormInput/index.tsx | Repositioned password visibility toggle; fixed autofill styling |
| src/components/CenteredLayout/index.tsx | Redesigned layout with background image and footer |
| public/assets/whoops.svg | Added new "Whoops" error illustration |
| public/assets/questdb.svg | Added QuestDB logo SVG |
| public/assets/plugs.svg | Added disconnection icon SVG |
| e2e/tests/enterprise/oidc.spec.js | Updated test expectations for new SSO button text |
| e2e/questdb | Updated subproject commit reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 21 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.