SavedScenario User Management via Engine #1686
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louispt1
force-pushed
the
saved-scenario-users
branch
from
ded041a to
2e950cc
Compare
This was referenced Dec 29, 2025
louispt1
force-pushed
the
saved-scenario-users
branch
2 times, most recently
from
29cf8e2 to
ec68d83
Compare
louispt1
force-pushed
the
saved-scenario-users
branch
from
ec68d83 to
a180647
Compare
noracato
requested changes
Jan 6, 2026
Member
noracato
left a comment
noracato
left a comment
There was a problem hiding this comment.
Adding all CRUD operations is a great idea.
Let's get a clear grip on who does what, and who holds the truth in the end. Like you said for SavedScenarios it should be myETM who's in control. Maybe we can draft a diagram about interactions and which app has which initiative.
Comment on lines
+382
to
+412
| def copy_roles_from_saved_scenario | ||
| saved_scenario_id = fetch_saved_scenario_id_for(parent.id) | ||
| return false unless saved_scenario_id | ||
|
|
||
| users_data = fetch_saved_scenario_users(saved_scenario_id) | ||
| return false unless users_data | ||
|
|
||
| users_data.each do |user_data| | ||
| scenario_users.create( | ||
| user_id: user_data['user_id'], | ||
| user_email: user_data['user_email'], | ||
| role_id: user_data['role_id'] | ||
| ) | ||
| end | ||
|
|
||
| true | ||
| rescue StandardError | ||
| false | ||
| end | ||
|
|
||
| def fetch_saved_scenario_id_for(scenario_id) | ||
| scenario = Scenario.find_by(id: scenario_id) | ||
| scenario&.metadata&.dig('saved_scenario_id') | ||
| end | ||
|
|
||
| def fetch_saved_scenario_users(saved_scenario_id) | ||
| response = ETEngine::MyEtm.client.get("/api/v1/saved_scenarios/#{saved_scenario_id}/users") | ||
| response.success? ? response.body : nil | ||
| rescue Faraday::Error | ||
| nil | ||
| end |
Member
There was a problem hiding this comment.
Let's rethink this.
- This feels more like a service or job, not core to the model. Mainly because it includes an API call to a resource which is potentially not owned by the user.
- The scenario can possibly belong to multiple saved scenarios. Where lies the truth: like you said this should be dictated by myETM, and indications about roles should then come from myETM, not from within the engine.
Comment on lines
+3
to
+18
| module ETEngine | ||
| # Handles communication with MyETM API. | ||
| module MyEtm | ||
| module_function | ||
|
|
||
| # Returns a Faraday client configured to communicate with MyETM. | ||
| def client | ||
| @client ||= Faraday.new(url: Settings.identity.issuer) do |conn| | ||
| conn.request(:json) | ||
| conn.response(:json) | ||
| conn.response(:raise_error) | ||
| conn.options.timeout = 5 | ||
| end | ||
| end | ||
| end | ||
| end |
Member
There was a problem hiding this comment.
Wondering about the use case of interacting with myETM not on behalf of the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a pass-through API that proxies SavedScenario user management requests to MyETM.
These changes, along with this Myetm PR allow users to manage roles on SavedScenarios via the Engine, and solidify the user coupling functionality so accounts are properly coupled based on the callback actions in MyETM.
Key changes:
/api/v3/saved_scenarios/:id/users)my_etm_clientfor other similar Faraday calls)Still to do
Relevant for this pyetm PR
Closes #1687