-
Notifications
You must be signed in to change notification settings - Fork 32
CompatHelper: bump compat for SciMLOperators to 1, (keep existing compat) #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for SciMLOperators to 1, (keep existing compat) #470
Conversation
dc3f6c4
to
c5f2ccb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
==========================================
- Coverage 94.08% 94.07% -0.01%
==========================================
Files 51 51
Lines 3533 3530 -3
==========================================
- Hits 3324 3321 -3
Misses 209 209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi, folks! This one seems to be a blocker for adding a QuantumToolbox backend to QuantumSymbolics. It seems QuantumSymbolics/QuantumOptics has a dependency on a more recent version of SciMLOperators, causing a clash in our downgrade check. It is potentially solvable on our end, but I wanted to first check whether you have plans to merge this in the near future, as it will simplify our work. |
This is an issue that troubled us for a long time since It returns incorrect results in some of our runtests. And we don't know what the problem is and how to fix it... |
Ah, that is frustrating... Some of your team are at JuliaCon right now, right? Let's meet up and corner Chris about it. In the meantime we will see whether there is some simple workaround we can use in QuantumSymbolics. Let's grab a meal together before/after the quantum mini symposium and we can discuss more. |
Yes, unfortunately, I cannot attend JuliaCon this time. |
Hi @Krastanov, yes I'm at JuliaCon, so we can discuss about it. I was planning to fix it after the conference. I don't expect huge changes, at least in the QuantumToolbox.jl side. I may expect to make some changes directly in SciMLOperators, as they have some regressions since v1.0: |
Ok, the previous PR in SciMLOperators.jl has been merged. I now opened this new one With all these changes all my local tests pass. So, let's wait a new release of SciMLOperators and we should be ready to merge this PR. |
In principle yes, in practice I have also asked to update SciMLBase, so that we can remove the custom method for But I can write a comment to remove that definition once a new version of SciMLBase is released. |
The quality error is due to piracy, as we are defining a new method for The Makie error is related to a newer version of Makie itself, which can be now installed probably due to compatibility with SciMLOperators.jl. I reduced the Makie version in the compat file. We can fix it separately in another PR. As you can see they have some deprecated functions. |
I agree with the For the Maybe we should also wait Up to you. |
317e087
to
455b24d
Compare
This pull request changes the compat entry for the
SciMLOperators
package from0.3, 0.4
to0.3, 0.4, 1
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.