Skip to content

Automated Resyntax fixes #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 21, 2025
Merged

Automated Resyntax fixes #1443

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
597ac0e
Fix 13 occurrences of `single-clause-match-to-match-define`
resyntax-ci[bot] Mar 21, 2025
d67d579
Fix 1 occurrence of `define-lambda-to-define`
resyntax-ci[bot] Mar 21, 2025
3bcaaa4
Fix 8 occurrences of `let-to-define`
resyntax-ci[bot] Mar 21, 2025
a5b1c3d
Fix 6 occurrences of `define-syntax-syntax-rules-to-define-syntax-rule`
resyntax-ci[bot] Mar 21, 2025
17ffc17
Fix 4 occurrences of `if-else-false-to-and`
resyntax-ci[bot] Mar 21, 2025
5fae6b4
Fix 1 occurrence of `inverted-when`
resyntax-ci[bot] Mar 21, 2025
2330432
Fix 2 occurrences of `zero-comparison-to-positive?`
resyntax-ci[bot] Mar 21, 2025
16cb2c9
Fix 1 occurrence of `define-simple-macro-to-define-syntax-parse-rule`
resyntax-ci[bot] Mar 21, 2025
ff2e657
Fix 1 occurrence of `provide-deduplication`
resyntax-ci[bot] Mar 21, 2025
851dbaa
Fix 1 occurrence of `if-let-to-cond`
resyntax-ci[bot] Mar 21, 2025
1a58a0a
Fix 1 occurrence of `apply-flattening`
resyntax-ci[bot] Mar 21, 2025
c93bc56
Fix 2 occurrences of `define-values-values-to-define`
resyntax-ci[bot] Mar 21, 2025
dd3d9ac
Fix 3 occurrences of `sort-with-keyed-comparator-to-sort-by-key`
resyntax-ci[bot] Mar 21, 2025
4aa242a
Fix 1 occurrence of `map-to-for`
resyntax-ci[bot] Mar 21, 2025
a712df6
Fix 3 occurrences of `quasiquote-to-list`
resyntax-ci[bot] Mar 21, 2025
68db708
Fix 1 occurrence of `for/fold-result-keyword`
resyntax-ci[bot] Mar 21, 2025
332a4ee
Fix 1 occurrence of `when-expression-in-for-loop-to-when-keyword`
resyntax-ci[bot] Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions typed-racket-lib/typed-racket/types/resolve.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@
(free-identifier=? n (poly-name (current-poly-struct))))
(define poly-num (length (poly-vars (current-poly-struct))))
(if (= poly-num (length rands))
(when (not (or (ormap Error? rands)
(andmap equal? rands
(poly-vars (current-poly-struct)))))
(unless (or (ormap Error? rands) (andmap equal? rands (poly-vars (current-poly-struct))))
(tc-error (~a "structure type constructor applied to non-regular arguments"
"\n type: " rator
"\n arguments...: " rands)))
"\n type: "
rator
"\n arguments...: "
rands)))
Comment on lines 65 to +69
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorawee A nice fmt improvement would be to keep description-value pairs adjacent in ~a and similar formatting expressions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly are considered "description-value pairs"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some examples:

  • The field v ... ... argument of raise-arguments-error.
  • Alternating pairs of strings and expressions in the arguments to ~a, ~v, ~s, etc.

That is, cases that construct the <field>: <detail> parts of an error message as described in Error Message Conventions. Not sure how easy it is to detect all of these though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's a good idea for the raise-arguments-error family and the hash family. I don't yet buy that the heuristic described for ~a will work well.

(tc-error (~a "wrong number of arguments to structure type constructor"
"\n type: " rator
"\n expected: " poly-num
Expand Down