Automated Resyntax fixes #1458
Closed
Automated Resyntax fixes #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=80&v=4){kind=small}
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
This `match` expression can be simplified using `match-define`.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This use of `format` does nothing.
Using `cond` instead of `if` here makes `begin` unnecessary
This use of `define-values` is unnecessary.
This negated `when` expression can be replaced by an `unless` expression.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `if`-`else` chain can be converted to a `cond` expression.
This `case-lambda` form only has one case. Use a regular lambda instead.
The `define` form supports a shorthand for defining functions.
This `if` expression can be refactored to an equivalent expression using `and`.
This list-constructing expression can be simplified
This `let` expression can be pulled up into a `define` expression.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
|
This seems to cause test failures, @jackfirth |
jackfirth
reviewed
Jun 23, 2025
Comment on lines
+97
to
+98
| (match-define (tc-result1: t) (tc-expr/check e t)) | ||
| t) |
There was a problem hiding this comment.
@samth I think this is the problem. Or something similar like this. Turns out match-define's semantics are a bit different than I expected: the t on the right hand side is bound to the t in the (tc-result1: t) pattern, not the t argument to tc-expr/check/t.
There was a problem hiding this comment.
This should be fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 38 issues in 20 files.
let-to-definedefine-lambda-to-definesingle-clause-match-to-match-definenested-if-to-condcond-let-to-cond-defineconsing-onto-static-listif-begin-to-condalways-throwing-if-to-whenif-else-false-to-andif-let-to-condcase-lambda-with-single-case-to-lambdadefine-values-values-to-definedefine-let-to-double-defineinverted-whenformat-identity