Make p8s an alias for pcs (escaped hex string) Fix #10058 #24729
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The p8s command was printing space-separated hex bytes, which was not intuitive. Many users expect it to print escaped hex strings like pcs does (e.g., "\x68\x65\x6c\x6c\x6f"). Changes: - Changed p8s to call pcs internally - Updated help message to clarify p8s is now an alias for pcs - Provides more intuitive behavior for creating escaped strings Before: p8s 11 → 68 65 6c 6c 6f 20 77 6f 72 6c 64 After: p8s 11 → "\x68\x65\x6c\x6c\x6f\x20\x77\x6f\x72\x6c\x64" This makes p8s behave as users naturally expect when looking for escaped hex string output. Fixes radareorg#10058
vicky-dx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The p8s command was printing space-separated hex bytes, which was not intuitive. Many users expect it to print escaped hex strings like pcs does (e.g., "\x68\x65\x6c\x6c\x6f").
Changes:
Before:
p8s 11 → 68 65 6c 6c 6f 20 77 6f 72 6c 64
After:
p8s 11 → "\x68\x65\x6c\x6c\x6f\x20\x77\x6f\x72\x6c\x64"
This makes p8s behave as users naturally expect when looking for escaped hex string output.
Fixes #10058