Skip to content

Conversation

@tiemvanderdeure
Copy link
Collaborator

Ran into this issue where if my directory contains both a foo.tif and a barbarbar.tif, then RasterStack("barbar.tif") errored.

Just replacing some indexing with startswith should fix that

@tiemvanderdeure
Copy link
Collaborator Author

Of course

ERROR: LoadError: HTTP.ConnectError for url = `[https://geodata.ucdavis.edu/climate/worldclim/2_1/base/wc2.1_10m_bio.zip`:](https://geodata.ucdavis.edu/climate/worldclim/2_1/base/wc2.1_10m_bio.zip%60:) TimeoutException: try_with_timeout timed out after 30.0 seconds

@tiemvanderdeure
Copy link
Collaborator Author

tiemvanderdeure commented Oct 13, 2025

Okay now test failures seem to be related to threaded rasterize runs. I remember reading something about some changes to how this works on 1.12?

Probably we are using threadid where we shouldn't, but I can't reproduce this locally

@rafaqz
Copy link
Owner

rafaqz commented Oct 14, 2025

Maybe they finally broke the :static flag. I hat that threading isn't covered by semver

@tiemvanderdeure
Copy link
Collaborator Author

I guess it is going to require a rewrite of _run to fix this? The docs do say threadid is not safe to use for buffers, but I cannot see what change in 1.12 actually broke this.

@rafaqz
Copy link
Owner

rafaqz commented Oct 14, 2025

That has been the case for a long time - do they explicitly say its not safe for :static now? We always use :static and that was the solution to using threadid in the past. Sad if thats gone, its faster and simpler.

(And yes we just have to rewrite _run)

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.72%. Comparing base (f1c4b75) to head (4c39744).
⚠️ Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
+ Coverage   82.89%   83.72%   +0.83%     
==========================================
  Files          58       68      +10     
  Lines        5425     5481      +56     
==========================================
+ Hits         4497     4589      +92     
+ Misses        928      892      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tiemvanderdeure
Copy link
Collaborator Author

I think we can merge this!

@rafaqz rafaqz merged commit e500c19 into rafaqz:main Nov 19, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants