feat: add input password as custom component #272

zhravan · 2025-07-06T13:55:20Z

Description:

This PR adds a new PasswordInput component with a show/hide password toggle (in view/components/ui).
Replaces all fields with the new component.

keploy · 2025-07-06T13:55:23Z

Keploy failed to create test cases for this PR. For retrying, please click here

coderabbitai · 2025-07-06T13:55:25Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

gitguardian · 2025-07-06T13:55:55Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

Copilot

Pull Request Overview

This PR introduces a reusable PasswordInput component with a show/hide toggle and replaces all existing <Input type="password"> fields across various forms with this new component. It also updates the API version’s release_date.

Add PasswordInput component under view/components/ui
Replace password fields in login, registration, reset, team management, and notification settings
Bump release_date for API v1 in api/api/versions.json

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
view/components/ui/password-input.tsx	New `PasswordInput` component with visibility toggle
view/components/features/login-form.tsx	Swap `<Input>` for `<PasswordInput>` on the login form
view/app/settings/teams/components/AddMember.tsx	Swap `<Input>` for `<PasswordInput>` in AddMember dialog
view/app/settings/notifications/components/channelTab.tsx	Swap SMTP password `<Input>` for `<PasswordInput>`
view/app/reset-password/components/ResetPasswordForm.tsx	Swap new/confirm password `<Input>` fields for `<PasswordInput>`
view/app/register/page.tsx	Swap registration password `<Input>` fields for `<PasswordInput>`
api/api/versions.json	Update API v1 `release_date`

Comments suppressed due to low confidence (1)

view/components/ui/password-input.tsx:48

Add unit tests for PasswordInput to verify the show/hide toggle behavior and ensure correct type switching.

export { PasswordInput };

Copilot · 2025-07-06T13:57:03Z

view/components/ui/password-input.tsx

+interface PasswordInputProps extends React.InputHTMLAttributes<HTMLInputElement> {
+  className?: string;
+}


The className prop is already included in React.InputHTMLAttributes<HTMLInputElement>, so it’s redundant here; consider removing the explicit declaration.

Suggested change

interface PasswordInputProps extends React.InputHTMLAttributes<HTMLInputElement> {

className?: string;

}

interface PasswordInputProps extends React.InputHTMLAttributes<HTMLInputElement> {}

Copilot · 2025-07-06T13:57:04Z

view/components/ui/password-input.tsx

+    const [showPassword, setShowPassword] = useState(false);
+
+    const togglePasswordVisibility = () => {
+      setShowPassword(!showPassword);


[nitpick] Use the functional update form setShowPassword(prev => !prev) to avoid potential stale state issues.

Suggested change

setShowPassword(!showPassword);

setShowPassword(prev => !prev);

Copilot · 2025-07-06T13:57:04Z

view/components/ui/password-input.tsx

+          size="sm"
+          className="absolute right-0 top-0 h-full px-3 py-2 hover:bg-transparent"
+          onClick={togglePasswordVisibility}
+          aria-label={showPassword ? 'Hide password' : 'Show password'}


Add aria-pressed={showPassword} to this button to clearly convey toggle state to assistive technologies.

Suggested change

aria-label={showPassword ? 'Hide password' : 'Show password'}

aria-label={showPassword ? 'Hide password' : 'Show password'}

aria-pressed={showPassword}

raghavyuva · 2025-08-20T18:19:35Z

closing this pull request @zhravan, if this is not duplicate of #342 then you can reopen this,

zhravan added 3 commits July 6, 2025 19:21

feat: add input password as custom component

c05b06c

feat: update for password login page

0d989d6

feat: include update everywhere wherever password input is required

d40e444

zhravan requested a review from raghavyuva July 6, 2025 13:55

raghavyuva added nixopus-view nixopus-api labels Jul 6, 2025

zhravan requested a review from Copilot July 6, 2025 13:55

Copilot AI reviewed Jul 6, 2025

View reviewed changes

zhravan removed the request for review from raghavyuva July 6, 2025 14:04

feat: include update everywhere wherever password input is required

2de96a1

raghavyuva assigned zhravan Jul 7, 2025

raghavyuva deleted the branch raghavyuva:feat/develop August 4, 2025 14:21

raghavyuva closed this Aug 4, 2025

raghavyuva reopened this Aug 4, 2025

raghavyuva closed this Aug 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add input password as custom component #272

feat: add input password as custom component #272

Uh oh!

zhravan commented Jul 6, 2025 •

edited

Loading

Uh oh!

keploy bot commented Jul 6, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 6, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

gitguardian bot commented Jul 6, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 6, 2025

Uh oh!

Copilot AI Jul 6, 2025

Uh oh!

Copilot AI Jul 6, 2025

Uh oh!

raghavyuva commented Aug 20, 2025

Uh oh!

Uh oh!

	setShowPassword(!showPassword);
	setShowPassword(prev => !prev);

	aria-label={showPassword ? 'Hide password' : 'Show password'}
	aria-label={showPassword ? 'Hide password' : 'Show password'}
	aria-pressed={showPassword}

Uh oh!

feat: add input password as custom component #272

feat: add input password as custom component #272

Uh oh!

Conversation

zhravan commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keploy bot commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jul 6, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

gitguardian bot commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

️✅ There are no secrets present in this pull request anymore.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 6, 2025

Choose a reason for hiding this comment

Uh oh!

raghavyuva commented Aug 20, 2025

Uh oh!

Uh oh!

zhravan commented Jul 6, 2025 •

edited

Loading

keploy bot commented Jul 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

gitguardian bot commented Jul 6, 2025 •

edited

Loading