Fix ERB syntax for development server connection #57
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When uncommenting the line (at the first hash), one would expect `connect_to_development_server` to reflect the result of `Rails.env.development?`, unless catching that the intended echo statement later in the same line was _also_ commented out. For the expected behavior, the `<%#` needs to also be uncommented as `<%=`, which is easy to miss and difficult to debug. Fixes rails#54.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uncommenting the line (at the first hash), one would expect
connect_to_development_serverto reflect the result ofRails.env.development?, unless catching that the intended echo statement later in the same line was also commented out. For the expected behavior, the<%#needs to also be uncommented as<%=, which is easy to miss and difficult to debug.Fixes #54.