feat: add string rule to the core rules #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chamber6821
suggested changes
Feb 17, 2021
src/Rules/String.php
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| use Rakit\Validation\Rule; | |||
|
|
|||
| class Alpha extends Rule | |||
| class String extends Rule | |||
There was a problem hiding this comment.
In PHP, case is often not important, so "String" cannot be used for the class name. It would be possible to write "StringRule", but this is not customary inside the library. I suggest renaming the class to "Text" and renaming the rule to "text". Maybe something doesn't sound right, I used a translator.
There was a problem hiding this comment.
Thanks Chamber6821.
That will teach me for doing too many things at once, late at night 😛
askme-gpt
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule allows for any value that returns true from
is_string($value).