fix: give clusterrole update on pvc #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

marcusramberg wants to merge 1 commit into rancher:master from marcusramberg:marcus/rbac_reprovision

Contributor

marcusramberg commented Oct 29, 2025

When provisioning fails, the controller tries to remove the selected node annotation to allow reprovisioning:

local-path-provisioner/vendor/sigs.k8s.io/sig-storage-lib-external-provisioner/v11/controller/controller.go

Line 1388 in 58a077d

delete(newClaim.Annotations, annSelectedNode)

But this fails with an RBAC error due to lack of permissions


          fix: give clusterrole update on pvc

c61720e

When provisioning fails, the controller tries to remove the selected node annotation to allow reprovisioning:
https://github.com/rancher/local-path-provisioner/blob/58a077d589c04c95f1720a78b9618ebe8e2abea8/vendor/sigs.k8s.io/sig-storage-lib-external-provisioner/v11/controller/controller.go#L1388
But this fails with an RBAC error due to lack of permissions

derekbit approved these changes

View reviewed changes

Member

derekbit left a comment

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet