added k8s-1.33-support #370
Conversation
swastik959
force-pushed
the
k8s-1.33-support
branch
from
7f4e417 to
fa386cd
Compare
|
This is not necessary for compatibility with Kubernetes 1.33. we should bump these deps at some point, but this is not necessary to make SUC work on Kubernetes 1.33, as it does not depend on any APIs or libraries that are changed in 1.33. |
|
@brandond can you confirm what changes need to be done for adding 1.33 support? |
|
No changes are necessary. It works fine on 1.33 as is. Its really not necessary to go around bumping everything to build with 1.33 just to make it work on 1.33. Unless there is something specific that has changed that is used by the project, Kubernetes apiservers are compatible with older clients. |
|
@brandond , thank you for looking into it. |
|
I'd like to get #369 merged first, then we can rebase this bump on top of that. Doesn't hurt anything to bump to latest k8s minor, its just not necessary from a compatibility standpoint. |
Understood - pinged @jakefhyde to review #369 |
|
Needs rebase, good to go after that. |
Signed-off-by: swastik959 <Sswastik959@gmail.com>
swastik959
force-pushed
the
k8s-1.33-support
branch
from
fa386cd to
022887a
Compare
Signed-off-by: swastik959 <Sswastik959@gmail.com>
swastik959
force-pushed
the
k8s-1.33-support
branch
from
d768bd0 to
de9d020
Compare
go.mod
Outdated
| ) | ||
|
|
||
| require ( | ||
| github.com/docker/distribution v2.8.3+incompatible | ||
| github.com/kubereboot/kured v1.13.1 | ||
| github.com/onsi/ginkgo/v2 v2.21.0 | ||
| github.com/onsi/gomega v1.35.1 | ||
| github.com/rancher/lasso v0.2.2 | ||
| github.com/rancher/lasso v0.2.3-rc3 |
There was a problem hiding this comment.
Should we un-rc wrangler and lasso?
cc @crobby
There was a problem hiding this comment.
@brandond wrangler v3.2.2 and lasso v0.2.3 both un-rcd.
There was a problem hiding this comment.
@swastik959 please update to the new non-rc tags.
go.mod
Outdated
| ) | ||
|
|
||
| require ( | ||
| github.com/docker/distribution v2.8.3+incompatible | ||
| github.com/kubereboot/kured v1.13.1 | ||
| github.com/onsi/ginkgo/v2 v2.21.0 | ||
| github.com/onsi/gomega v1.35.1 | ||
| github.com/rancher/lasso v0.2.2 | ||
| github.com/rancher/lasso v0.2.3-rc3 |
There was a problem hiding this comment.
@swastik959 please update to the new non-rc tags.
Signed-off-by: swastik959 <Sswastik959@gmail.com>
Fixes K8's 1.33 support for system upgrade controller rancher#50437