Skip to content

Add gcc-15 + Ubuntu 25.04 #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: branch-25.08
Choose a base branch
from
Open

Add gcc-15 + Ubuntu 25.04 #516

wants to merge 6 commits into from

Conversation

wmaxey
Copy link
Contributor

@wmaxey wmaxey commented May 19, 2025

No description provided.

@wmaxey wmaxey requested a review from a team as a code owner May 19, 2025 21:31
@wmaxey wmaxey requested review from AyodeAwe and removed request for a team May 19, 2025 21:31
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 19, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

trxcllnt
trxcllnt requested changes May 20, 2025
View reviewed changes
Copy link
Collaborator

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to bump the version in features/src/gcc/devcontainer-feature.json

@trxcllnt
Copy link
Collaborator

/ok to test 472d6cd

@wmaxey
Copy link
Contributor Author

wmaxey commented May 20, 2025

need to bump the version in features/src/gcc/devcontainer-feature.json

To what? 25.8.1? Sorry I'm unfamiliar with the process on these files and when looking at the blame any updates seem to match the branch version.

@trxcllnt
Copy link
Collaborator

@wmaxey yeah, just bump the patch version in that file

@trxcllnt
Copy link
Collaborator

/ok to test 22d1101

trxcllnt
trxcllnt requested changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing back to request changes due to more questions.

@wmaxey wmaxey changed the title Add gcc-15 by fetching from 25.04 ppa. Add gcc-15 + Ubuntu 25.04 May 23, 2025
@trxcllnt
Copy link
Collaborator

/ok to test 06f2e8b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmaxey @trxcllnt